linux-kernel - Re: [PATCH v7] ACPI: fan: Add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 12 May 2024 08:20:01 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andy.shevchenko@...il.com>, Armin Wolf <W_Armin@....de>
Cc: mlj@...elec.com, rafael.j.wysocki@...el.com, lenb@...nel.org,
 jdelvare@...e.com, linux@...ssschuh.net, ilpo.jarvinen@...ux.intel.com,
 linux-acpi@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v7] ACPI: fan: Add hwmon support

On 5/10/24 06:30, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 1:19 AM Armin Wolf <W_Armin@....de> wrote:
>>
>> Currently, the driver does only support a custom sysfs
>> interface to allow userspace to read the fan speed.
>> Add support for the standard hwmon interface so users
>> can read the fan speed with standard tools like "sensors".
> 
>> Tested with a custom ACPI SSDT.
> 
> This most likely fits the comment/changelog area and not the commit
> message. Also would be good to put there the link to this custom SSDT
> (like one of zillion of pastebin sites, or GitHub, or ...).
> 
> I was under the impression that Guenter gave a tag, which is missing,
> but no, he just said it's okay to go. Guenter, maybe a formal
> Acked-by?
> 

I said

It all seems odd, and I returning -ENODATA doesn't seem right,
but then I don't understand the specification or the logic behind it, and
I don't have the time to read and understand it. No objection from my side
against moving forward.

This isn't sufficient for anything formal. Just go ahead.

Thanks,
Guenter