linux-kernel - Re: [PATCH] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 10 May 2024 21:55:30 +0530
From: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, Gabor Juhos <j4g8y7@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Varadarajan Narayanan
	<quic_varada@...cinc.com>,
        Gokul Sriram Palanisamy
	<quic_gokulsri@...cinc.com>
Subject: Re: [PATCH] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from
 Stromer pll configs



On 5/10/2024 12:23 AM, Konrad Dybcio wrote:
> On 9.05.2024 10:08 AM, Gabor Juhos wrote:
>> Since the CONFIG_CTL register is only 32 bits wide in the Stromer
>> and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the
>> IPQ5018 and IPQ5332 configurations are not used so remove those.
>>
>> No functional changes.
>>
>> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
>> ---
> 
> Hm, it sounds suspicious that we'd have these settings then.. Could somebody from
> QC please confirm that everything's alright here?


I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U 
register is not implemented. I see offset of CONFIG_CTL_U register is 
removed in the change[1] by Gabor.

Given that, should we also drop the pll_has_64bit_config() if block from 
clk_stromer_pll_configure function?

Nevertheless, for this patch

Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4f2bc4acbb19

> 
> Konrad