linux-kernel - Re: [PATCH linux-next] mm/huge_memory: remove redundant locking when parsing THP sysfs input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zj-XOV08WBX33OJw@casper.infradead.org>
Date: Sat, 11 May 2024 17:05:13 +0100
From: Matthew Wilcox <willy@...radead.org>
To: xu.xin16@....com.cn
Cc: akpm@...ux-foundation.org, david@...hat.com, shy828301@...il.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re:  [PATCH linux-next] mm/huge_memory: remove redundant locking when parsing THP sysfs input

On Sat, May 11, 2024 at 02:40:48PM +0800, xu.xin16@....com.cn wrote:
> From: Ran Xiaokai <ran.xiaokai@....com.cn>
> 
> Since sysfs_streq() only performs a simple memory comparison operation
> and will not introduce any sleepable operation, So there is no
> need to drop the lock when parsing input. Remove redundant lock
> and unlock operations to make code cleaner.

i disagree that it makes the code cleaner.