linux-kernel - Re: [PATCH linux-next] mm/huge_memory: remove redundant locking when parsing THP sysfs input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240511143504.2d5dae49d4c76e6608b7cc93@linux-foundation.org>
Date: Sat, 11 May 2024 14:35:04 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: xu.xin16@....com.cn, david@...hat.com, shy828301@...il.com,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org, Muchun Song
 <muchun.song@...ux.dev>
Subject: Re:  [PATCH linux-next] mm/huge_memory: remove
 redundant locking when parsing THP sysfs input


(cc Muchun)

On Sat, 11 May 2024 17:05:13 +0100 Matthew Wilcox <willy@...radead.org> wrote:

> On Sat, May 11, 2024 at 02:40:48PM +0800, xu.xin16@....com.cn wrote:
> > From: Ran Xiaokai <ran.xiaokai@....com.cn>
> > 
> > Since sysfs_streq() only performs a simple memory comparison operation
> > and will not introduce any sleepable operation, So there is no
> > need to drop the lock when parsing input. Remove redundant lock
> > and unlock operations to make code cleaner.
> 
> i disagree that it makes the code cleaner.

Oh.  Why is that?  The end result looks nice to me and saves a bit of
text.