linux-kernel - Re: [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking supported commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565b4f5b-524b-4093-9c24-9e34cd0643f2@gmx.de>
Date: Sun, 12 May 2024 20:00:29 +0200
From: Armin Wolf <W_Armin@....de>
To: Lyndon Sanche <lsanche@...deno.ca>
Cc: mario.limonciello@....com, pali@...nel.org,
 srinivas.pandruvada@...ux.intel.com, ilpo.jarvinen@...ux.intel.com,
 lkp@...el.com, hdegoede@...hat.com, Yijun.Shen@...l.com,
 Matthew Garrett <mjg59@...f.ucam.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Randy Dunlap <rdunlap@...radead.org>,
 Vegard Nossum <vegard.nossum@...cle.com>,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Dell.Client.Kernel@...l.com
Subject: Re: [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking
 supported commands

Am 11.05.24 um 04:36 schrieb Lyndon Sanche:

> Add symbol to check if a specific class of smbios command is supported.
>
> Signed-off-by: Lyndon Sanche <lsanche@...deno.ca>
> ---
>   drivers/platform/x86/dell/dell-smbios-base.c | 6 ++++++
>   drivers/platform/x86/dell/dell-smbios.h      | 1 +
>   2 files changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c
> index e61bfaf8b5c4..6ae09d7f76fb 100644
> --- a/drivers/platform/x86/dell/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell/dell-smbios-base.c
> @@ -350,6 +350,12 @@ void dell_laptop_call_notifier(unsigned long action, void *data)
>   }
>   EXPORT_SYMBOL_GPL(dell_laptop_call_notifier);
>
> +bool dell_laptop_check_supported_cmds(u16 class)
> +{

Hi,

the function dell_smbios_call_filter() says that classes above 30 are always unsupported,
so please check this here too.

Also please rename the function to something like dell_smbios_class_is_supported().

Other than that:
Reviewed-by: Armin Wolf <W_Armin@....de>

> +	return da_supported_commands & (1 << class);
> +}
> +EXPORT_SYMBOL_GPL(dell_laptop_check_supported_cmds);
> +
>   static void __init parse_da_table(const struct dmi_header *dm)
>   {
>   	/* Final token is a terminator, so we don't want to copy it */
> diff --git a/drivers/platform/x86/dell/dell-smbios.h b/drivers/platform/x86/dell/dell-smbios.h
> index eb341bf000c6..63116671eada 100644
> --- a/drivers/platform/x86/dell/dell-smbios.h
> +++ b/drivers/platform/x86/dell/dell-smbios.h
> @@ -73,6 +73,7 @@ enum dell_laptop_notifier_actions {
>   int dell_laptop_register_notifier(struct notifier_block *nb);
>   int dell_laptop_unregister_notifier(struct notifier_block *nb);
>   void dell_laptop_call_notifier(unsigned long action, void *data);
> +bool dell_laptop_check_supported_cmds(u16 class);
>
>   /* for the supported backends */
>   #ifdef CONFIG_DELL_SMBIOS_WMI