linux-kernel - Re: [PATCH v6 4/9] iio: pressure: bmp280: Use unsigned data types for raw sensor data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240512131304.687de3b1@jic23-huawei>
Date: Sun, 12 May 2024 13:13:04 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, andriy.shevchenko@...ux.intel.com,
 ang.iglesiasg@...il.com, mazziesaccount@...il.com, ak@...klinger.de,
 petre.rodan@...dimension.ro, phil@...pberrypi.com, 579lpy@...il.com,
 linus.walleij@...aro.org, semen.protsenko@...aro.org,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 4/9] iio: pressure: bmp280: Use unsigned data types
 for raw sensor data

On Wed,  8 May 2024 18:52:02 +0200
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> The raw sensor data that have not been compensated yet cannot be
> signed values, so use unsigned ones. Also, compensated pressure
> values cannot be negative so use unsigned also there.
> 
> Also, drop redundant cast of data->t_fine variable from s32 to s32.
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
Looks good to me.

Applied.