linux-kernel - Re: [PATCH] power: supply: sbs-manager: Remove class argument from i2c_mux_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 13 May 2024 23:17:48 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-i2c@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>, 
	Peter Rosin <peda@...ntia.se>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, "Rob Herring (Arm)" <robh@...nel.org>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: sbs-manager: Remove class argument from
 i2c_mux_add_adapter()

Hi Wolfram,

On Mon, May 13, 2024 at 10:11:16PM +0200, Wolfram Sang wrote:
> Commit 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based
> device instantiation") removed the last call to i2c_mux_add_adapter()
> with a non-null class argument. Therefore the class argument can be
> removed.
> 
> Note: Class-based device instantiation is a legacy mechanism which
> shouldn't be used in new code, so we can rule out that this argument
> may be needed again in the future.
> 
> This driver was forgotten by the patch in the Fixes tag.
> 
> Fixes: fec1982d7072 ("i2c: mux: Remove class argument from i2c_mux_add_adapter()")
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> 
> The to-be-fixed patch is only in linux-next in my i2c/for-next tree. We
> want to remove this unneeded parameter in the next mergewindow. I
> suggest that I just put it on top of my branch to avoid the
> dependencies. A quick ack would be super-awesome! Thanks.

Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  drivers/power/supply/sbs-manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sbs-manager.c
> index 9e4141cffbf9..933b04806d10 100644
> --- a/drivers/power/supply/sbs-manager.c
> +++ b/drivers/power/supply/sbs-manager.c
> @@ -358,7 +358,7 @@ static int sbsm_probe(struct i2c_client *client)
>  	/* register muxed i2c channels. One for each supported battery */
>  	for (i = 0; i < SBSM_MAX_BATS; ++i) {
>  		if (data->supported_bats & BIT(i)) {
> -			ret = i2c_mux_add_adapter(data->muxc, 0, i + 1, 0);
> +			ret = i2c_mux_add_adapter(data->muxc, 0, i + 1);
>  			if (ret)
>  				break;
>  		}
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)