linux-kernel - Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240513141906.GA2534611-robh@kernel.org>
Date: Mon, 13 May 2024 09:19:06 -0500
From: Rob Herring <robh@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Michael Hennerich <michael.hennerich@...log.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node
 name

On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> It is always recommended to use generic node names for devicetree nodes.
> The documentation [1] of the AXI ADC IP core says "The most important
> part of the core is the Receiver PHY module.", so using phy as the node
> name seems appropriate.
> 
> [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index e1f450b80db2..9cad4c439045 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -57,7 +57,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    axi-adc@...00000 {
> +    phy@...00000 {

phy should be used when there's #phy-cells which is not the case here. 
'adc' is somewhat standard. Or maybe it should be tied to 
#io-backend-cells.

Until we have something defined as ti what it should be, we should just 
leave node names alone.

Rob