linux-kernel - Re: [PATCH v2 2/2] Add dp PHY dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1eb69265ae15323f3304f1c4b4fb0be5b13f1d42.camel@mediatek.com>
Date: Tue, 14 May 2024 04:43:03 +0000
From: LIANKUN YANG (杨连坤) <Liankun.Yang@...iatek.com>
To: "robh+dt@...nel.org" <robh+dt@...nel.org>,
	Mac Shen (沈俊) <Mac.Shen@...iatek.com>,
	Chunfeng Yun (云春峰) <Chunfeng.Yun@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "krzk@...nel.org"
	<krzk@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	Jitao Shi (石记涛) <jitao.shi@...iatek.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "daniel@...ll.ch"
	<daniel@...ll.ch>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "kishon@...nel.org"
	<kishon@...nel.org>, "airlied@...il.com" <airlied@...il.com>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] Add dp PHY dt-bindings

On Mon, 2024-05-13 at 16:20 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 13/05/2024 16:17, Krzysztof Kozlowski wrote:
> >>> dp.yaml
> >>>> @@ -0,0 +1,45 @@
> >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>>> +%YAML 1.2
> >>>> +---
> >>>> +$id: 
> >>> 
> http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml#
> >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>>> +
> >>>> +title: MediaTek Display Port Controller
> >>>> +
> >>>> +maintainers:
> >>>> +  - Mac shen <mac.shen@...iatek.com>
> >>>> +  - Liankun yang <Liankun.yang@...iatek.com>
> >>>> +
> >>>> +description: |
> >>>> +  Special settings need to be configured by MediaTek DP based
> on
> >>> the actual
> >>>> +  hardware situation. For example, when using a certain brand's
> >>> docking
> >>>> +  station for display projection, garbage may appear. Adjusting
> >>> the specific
> >>>> +  ssc value can resolve this issue.
> >>>> +
> >>>> +properties:
> >>>> +  status: disabled
> >>>
> >>> I think you nicely shocked Rob already.
> >>>
> >>> Please reach internally to Mediatek or collaborating companies to
> get
> >>> basic training and instructions how to write patches and
> bindings.
> >>>
> >>> Otherwise it is waste of our time. Mediatek is not a small
> company so
> >>> there is no excuse in sending such poor quality patches, which
> would
> >>> be
> >>> EASILY spotted by the MOST BASIC review.
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>>
> >>
> >> I used scripts/checkpatch.pl and fix reported error and warnings.
> >> I am resumbmitting bindings by the MOST BASIC review.
> > 
> > No, please wait. Who did the basic review of your patch? Who from
> > Mediatek? Upstream is not a workhorse to use instead of your
> resources
> > for the absolute basic stuff... This feels such exploiting.
> > 
> 
> After reading AngeloGioacchino's response, it looks even worse...
> This
> was never tested...
> 
> So not only exploiting but also feels like wasting our time.
> 
> Best regards,
> Krzysztof
> 


Sorry,I guess I didn't make myself clear.
I am resumbmitting bindings after the MOST BASIC internal review.
Thank you for your comment.

Best Regards,
Liankun Yang