[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<CYYPR12MB8655C82734A252F7983A9EF49CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
Date: Tue, 14 May 2024 04:51:22 +0000
From: "Yuan, Perry" <Perry.Yuan@....com>
To: "zhida312@...look.com" <zhida312@...look.com>, "rafael@...nel.org"
<rafael@...nel.org>, "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
"Shenoy, Gautham Ranjal" <gautham.shenoy@....com>
CC: Peng Ma <andypma@...cent.com>, "Huang, Ray" <Ray.Huang@....com>,
"Limonciello, Mario" <Mario.Limonciello@....com>, "linux-pm@...r.kernel.org"
<linux-pm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp
exist
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Peng,
> -----Original Message-----
> From: zhida312@...look.com <zhida312@...look.com>
> Sent: Tuesday, May 14, 2024 11:17 AM
> To: rafael@...nel.org; viresh.kumar@...aro.org
> Cc: Peng Ma <andypma@...cent.com>; Huang, Ray <Ray.Huang@....com>;
> Shenoy, Gautham Ranjal <gautham.shenoy@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Yuan, Perry <Perry.Yuan@....com>; linux-
> pm@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp exist
>
> From: andypma <andypma.tencent.com>
>
> the cpudata memory from kzmalloc in epp init function is not free after epp exist,
> so we should free it.
>
> Signed-off-by: Peng Ma <andypma@...cent.com>
> ---
> drivers/cpufreq/amd-pstate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 2db095867d03..96a323f59a93 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1425,6 +1425,9 @@ static int amd_pstate_epp_cpu_init(struct
> cpufreq_policy *policy)
>
> static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) {
> + struct amd_cpudata *cpudata = policy->driver_data;
> +
> + kfree(cpudata);
> pr_debug("CPU %d exiting\n", policy->cpu);
> return 0;
> }
> --
> 2.33.0
Thanks for the patch, how about change to be like below?
if (cpudata) {
kfree(cpudata);
policy->driver_data = NULL;
}
Perry.
Powered by blists - more mailing lists