linux-kernel - Re: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR01MB5101C760CD59A20D411F31E992E32@TYZPR01MB5101.apcprd01.prod.exchangelabs.com>
Date: Tue, 14 May 2024 14:27:07 +0800
From: mazhida <zhida312@...look.com>
To: "Yuan, Perry" <Perry.Yuan@....com>
Cc: "rafael@...nel.org" <rafael@...nel.org>,
 "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@....com>,
 Peng Ma <andypma@...cent.com>,
 "Huang, Ray" <Ray.Huang@....com>,
 "Limonciello, Mario" <Mario.Limonciello@....com>,
 "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp
 exist

Hi Perry,

	Yes，Of course.

BR,
Peng

> 2024年5月14日 12:51，Yuan, Perry <Perry.Yuan@....com> 写道：
> 
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Peng,
> 
>> -----Original Message-----
>> From: zhida312@...look.com <zhida312@...look.com>
>> Sent: Tuesday, May 14, 2024 11:17 AM
>> To: rafael@...nel.org; viresh.kumar@...aro.org
>> Cc: Peng Ma <andypma@...cent.com>; Huang, Ray <Ray.Huang@....com>;
>> Shenoy, Gautham Ranjal <gautham.shenoy@....com>; Limonciello, Mario
>> <Mario.Limonciello@....com>; Yuan, Perry <Perry.Yuan@....com>; linux-
>> pm@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp exist
>> 
>> From: andypma <andypma.tencent.com>
>> 
>> the cpudata memory from kzmalloc in epp init function is not free after epp exist,
>> so we should free it.
>> 
>> Signed-off-by: Peng Ma <andypma@...cent.com>
>> ---
>> drivers/cpufreq/amd-pstate.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
>> 2db095867d03..96a323f59a93 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -1425,6 +1425,9 @@ static int amd_pstate_epp_cpu_init(struct
>> cpufreq_policy *policy)
>> 
>> static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
>> +     struct amd_cpudata *cpudata = policy->driver_data;
>> +
>> +     kfree(cpudata);
>>   pr_debug("CPU %d exiting\n", policy->cpu);
>>   return 0;
>> }
>> --
>> 2.33.0
> 
> Thanks for the patch, how about change to be like below?
> 
> if (cpudata) {
>     kfree(cpudata);
>     policy->driver_data = NULL;
> }
> 
> Perry.
>