linux-kernel - Re: [GIT PULL] x86/boot changes for v6.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHm_tmBPNTvnvn3r6myeRo5x1fX3_J73UA1j4bVBo_PSg@mail.gmail.com>
Date: Tue, 14 May 2024 09:27:14 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org, 
	"the arch/x86 maintainers" <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [GIT PULL] x86/boot changes for v6.10

On Tue, 14 May 2024 at 03:03, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sun, 12 May 2024 at 23:51, Ingo Molnar <mingo@...nel.org> wrote:
> >
> >  - Re-introduce a bootloader quirk wrt. CR4 handling
>
> I've pulled this, but shouldn't the compressed boot also just stop
> setting the G flag that it didn't understand?
>

I agree. But not setting CR4 to a known value is what caused the
regression, and that could cause other problems down the road, so
fixing it was arguably more important.

More than happy to send another patch to clear the G bit from the page
table entries created by the decompressor, but at this point, it
shouldn't make a difference.