linux-kernel - Re: [PATCH net-next] netconsole: Do not shutdown dynamic configuration if cmdline is invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 14 May 2024 05:06:26 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	thepacketgeek@...il.com, Aijay Adams <aijay@...a.com>,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] netconsole: Do not shutdown dynamic
 configuration if cmdline is invalid

On Mon, May 13, 2024 at 02:51:29PM -0700, Jakub Kicinski wrote:
> On Fri, 10 May 2024 03:30:05 -0700 Breno Leitao wrote:
> > +static inline bool dynamic_netconsole_enabled(void)
> > +{
> > +	return IS_ENABLED(CONFIG_NETCONSOLE_DYNAMIC);
> > +}
> 
> Why the separate static inline?

I thought it would make the code easier to read.

> We can put IS_ENABLED.. directly in the if condition.

Sure. I will send a v2 with the IS_ENABLED() inside the if condition.

Thanks for the review.