[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <16f79b3f-0b33-4196-858a-b1469ed1200b@lunn.ch>
Date: Tue, 14 May 2024 15:08:59 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
MD Danish Anwar <danishanwar@...com>,
Ravi Gunasekaran <r-gunasekaran@...com>
Subject: Re: [PATCH 2/2] net: phy: dp83869: Fix RGMII-SGMII and 1000BASE-X
> +/* FX_CTRL bits */
> +#define DP83869_CTRL0_SPEED_SEL_MSB BIT(6)
> +#define DP83869_CTRL0_DUPLEX_MODE BIT(8)
> +#define DP83869_CTRL0_RESTART_AN BIT(9)
> +#define DP83869_CTRL0_ISOLATE BIT(10)
> +#define DP83869_CTRL0_PWRDN BIT(11)
> +#define DP83869_CTRL0_ANEG_EN BIT(12)
> +#define DP83869_CTRL0_SPEED_SEL_LSB BIT(13)
> +#define DP83869_CTRL0_LOOPBACK BIT(14)
This looks like a standard BMCR. Please just use defines from mii.h,
since they are well known.
> +/* FX_STS bits */
> +#define DP83869_STTS_LINK_STATUS BIT(2)
> +#define DP83869_STTS_ANEG_COMPLETE BIT(5)
And these are standard BMCR bits.
> +
> +/* FX_ANADV bits */
> +#define DP83869_BP_FULL_DUPLEX BIT(5)
> +#define DP83869_BP_HALF_DUPLEX BIT(6)
> +#define DP83869_BP_PAUSE BIT(7)
> +#define DP83869_BP_ASYMMETRIC_PAUSE BIT(8)
ADVERTISE_1000XPSE_ASYN, ADVERTISE_1000XPAUSE, ...
Please go through all these defines and see what match to existing
ones.
Andrew
Powered by blists - more mailing lists