linux-kernel - Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45e0aee9-87d5-434f-8ffe-d3270def0f72@kernel.org>
Date: Tue, 14 May 2024 15:27:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Komal Bajaj <quic_kbajaj@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Melody Olvera <quic_molvera@...cinc.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage
 setting

On 14/05/2024 15:10, Komal Bajaj wrote:
> Fixing the regulator voltages for qdu/qru1000 idp boards.
> In particular -
> - smps4 is 1.574V min and 2.04V max
> - smps5 is 1.2V min and 1.4V max
> - smps6 is 0.382V min and 1.12V max

Wait, why? This looks, at least partially, you are changing from fixed
voltage choice to full range, without clear explanation.

> - smps8 is fixed at 0.752V


> 
> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>

Best regards,
Krzysztof