linux-kernel - Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c214d8b-9c59-7266-4c80-4b548ad6c7f9@quicinc.com>
Date: Thu, 16 May 2024 11:22:15 +0530
From: Komal Bajaj <quic_kbajaj@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: Melody Olvera <quic_molvera@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage
 setting



On 5/14/2024 6:57 PM, Krzysztof Kozlowski wrote:
> On 14/05/2024 15:10, Komal Bajaj wrote:
>> Fixing the regulator voltages for qdu/qru1000 idp boards.
>> In particular -
>> - smps4 is 1.574V min and 2.04V max
>> - smps5 is 1.2V min and 1.4V max
>> - smps6 is 0.382V min and 1.12V max
> 
> Wait, why? This looks, at least partially, you are changing from fixed
> voltage choice to full range, without clear explanation.
> 

When we started using one of these regulators for USB enablement as sent 
in the patch series [1], we saw a sudden reboot.
After adding more debug logs, came to know the configuration for smps5 
was incorrect.

Therefore, cross verified the configurations for all the regulators and 
got to know that these are incorrectly configured.
This fixes some manual errors introduced in the initial patch (mentioned 
in fixes tag).

[1] 
https://lore.kernel.org/linux-arm-msm/20240502090326.21489-1-quic_kbajaj@quicinc.com/

Thanks,
Komal.


>> - smps8 is fixed at 0.752V
> 
> 
>>
>> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
>> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
> 
> Best regards,
> Krzysztof
>