linux-kernel - Re: [PATCH] mm/ksm: fix possible UAF of stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74a72eeb-122f-453e-baa7-63504e7c4bd8@redhat.com>
Date: Tue, 14 May 2024 22:46:44 +0200
From: David Hildenbrand <david@...hat.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>,
 Andrew Morton <akpm@...ux-foundation.org>, Hugh Dickins <hughd@...gle.com>,
 Andrea Arcangeli <aarcange@...hat.com>, Stefan Roesch <shr@...kernel.io>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 zhouchengming@...edance.com
Subject: Re: [PATCH] mm/ksm: fix possible UAF of stable_node

On 13.05.24 05:07, Chengming Zhou wrote:
> The commit 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page
> deduplication limit") introduced a possible failure case in the
> stable_tree_insert(), where we may free the new allocated stable_node_dup
> if we fail to prepare the missing chain node.
> 
> Then that kfolio return and unlock with a freed stable_node set... And
> any MM activities can come in to access kfolio->mapping, so UAF.
> 
> Fix it by moving folio_set_stable_node() to the end after stable_node
> is inserted successfully.
> 
> Fixes: 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page deduplication limit")
> Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>
> ---
>   mm/ksm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index e1034bf1c937..a8b76af5cf64 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -2153,7 +2153,6 @@ static struct ksm_stable_node *stable_tree_insert(struct folio *kfolio)
>   
>   	INIT_HLIST_HEAD(&stable_node_dup->hlist);
>   	stable_node_dup->kpfn = kpfn;
> -	folio_set_stable_node(kfolio, stable_node_dup);
>   	stable_node_dup->rmap_hlist_len = 0;
>   	DO_NUMA(stable_node_dup->nid = nid);
>   	if (!need_chain) {
> @@ -2172,6 +2171,8 @@ static struct ksm_stable_node *stable_tree_insert(struct folio *kfolio)
>   		stable_node_chain_add_dup(stable_node_dup, stable_node);
>   	}
>   
> +	folio_set_stable_node(kfolio, stable_node_dup);
> +
>   	return stable_node_dup;

Looks correct to me.

We might now link the node before the folio->mapping is set up. Do we 
care? Don't think so.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb