linux-kernel - Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 15 May 2024 22:51:43 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Esther Shimanovich <eshimanovich@...omium.org>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Rajat Jain <rajatja@...gle.com>
Subject: Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

On Wed, May 15, 2024 at 10:35:22PM +0200, Lukas Wunner wrote:
> On Wed, May 15, 2024 at 02:53:54PM -0400, Esther Shimanovich wrote:
> > On Wed, May 8, 2024 at 1:23???AM Lukas Wunner <lukas@...ner.de> wrote:
> > > On Wed, May 01, 2024 at 06:23:28PM -0400, Esther Shimanovich wrote:
> > > > On Sat, Apr 27, 2024 at 3:17AM Lukas Wunner <lukas@...ner.de> wrote:
> > > > That is correct, when the user-visible issue occurs, no driver is
> > > > bound to the NHI and XHCI. The discrete JHL chip is not permitted to
> > > > attach to the external-facing root port because of the security
> > > > policy, so the NHI and XHCI are not seen by the computer.
> > >
> > > Could you rework your patch to only rectify the NHI's and XHCI's
> > > device properties and leave the bridges untouched?
> > 
> > So I tried a build with that patch, but it never reached the
> > tb_pci_fixup function

Hm, re-reading your e-mail I'm irritated that you're referring to
"that patch" (singular).  You need at least these five commits:

  thunderbolt: Move struct tb_cm to tb.h
  thunderbolt: Obtain PCIe Device/Function number from DROM
  thunderbolt: Obtain PCIe Device/Function number via Router Operation
  thunderbolt: Associate PCI devices with PCIe Adapters
  thunderbolt: Mark PCIe Adapters on root switch as non-removable

on this branch:

  https://github.com/l1k/linux/commits/thunderbolt_associate_v1

Thanks,

Lukas