linux-kernel - Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Y6NJGemB2Jue6hK766571AxxFSZKissRFt4C9y994xRQ2_MQ@mail.gmail.com>
Date: Wed, 15 May 2024 17:44:02 -0400
From: Esther Shimanovich <eshimanovich@...omium.org>
To: Lukas Wunner <lukas@...ner.de>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Mario Limonciello <mario.limonciello@....com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Rajat Jain <rajatja@...gle.com>
Subject: Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

> Hm, why would I have to distinguish between the two?
>
> I distinguish between Thunderbolt PCIe Adapters on the root switch
> and ones on non-root switches.  The latter are attached Device Routers,
> the former is the Host Router.  I just set the ones on the former to
> external_facing, fixed and trusted.  Everything downstream is untrusted
> and removable.

Thanks for the explanation. I'll try adding the kernel config and
command line parameters you mentioned, and share any additional debug
info I find.
What I did previously was use a pr_info line inside the tb_pci_fixup
function. That's how I knew that the function wasn't visited.

I am testing on ChromeOS on a non-ChromeBook so there might be some
additional security settings that prevent the Thunderbolt driver from
being loaded. I remember running into them when I first tried to debug
this.
That may be what is preventing your patch from working as intended on
my device. I will have to look into what could be causing that.

On Wed, May 15, 2024 at 4:51 PM Lukas Wunner <lukas@...ner.de> wrote:
>
> Hm, re-reading your e-mail I'm irritated that you're referring to
> "that patch" (singular).  You need at least these five commits:
>
>   thunderbolt: Move struct tb_cm to tb.h
>   thunderbolt: Obtain PCIe Device/Function number from DROM
>   thunderbolt: Obtain PCIe Device/Function number via Router Operation
>   thunderbolt: Associate PCI devices with PCIe Adapters
>   thunderbolt: Mark PCIe Adapters on root switch as non-removable
>
> on this branch:
>
>   https://github.com/l1k/linux/commits/thunderbolt_associate_v1

I should have specified "patch series" instead of patch. I did include
all of your patches, and I used that branch you linked earlier!
git log --pretty=short --oneline
2e83bc05d285 (HEAD -> integration) thunderbolt: Do not bind to Host
Interface exposed by Device Router
01782fd462f2 thunderbolt: Mark PCIe Adapters on Root Switch as non-removable
814d0a7b0da8 thunderbolt: Associate PCI devices with PCIe Adapters
06b2f200532f thunderbolt: Obtain PCIe Device/Function number via
Router Operation
03d532c8a59f thunderbolt: Obtain PCIe Device/Function number from DROM
d710d8b828c5 thunderbolt: Move struct tb_cm to tb.h

I very much appreciate your help with this! I am happy to dig deeper
to figure out what is going on, I just wanted to share where I was so
that I could get additional support, and be guided in the right
direction. Thank you!