[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACGkMEtxYsRhxRc_DExPXeSLOstp0D66+yEoyXKVWrMdTx5ASw@mail.gmail.com>
Date: Thu, 16 May 2024 13:03:23 +0800
From: Jason Wang <jasowang@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org,
syzbot+6c21aeb59d0e82eb2782@...kaller.appspotmail.com,
Jeongjun Park <aha310510@...il.com>, Arseny Krasnov <arseny.krasnov@...persky.com>,
"David S . Miller" <davem@...emloft.net>, Stefan Hajnoczi <stefanha@...hat.com>,
Stefano Garzarella <sgarzare@...hat.com>, Eugenio Pérez <eperezma@...hat.com>,
kvm@...r.kernel.org, virtualization@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH] vhost/vsock: always initialize seqpacket_allow
On Wed, May 15, 2024 at 11:05 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> There are two issues around seqpacket_allow:
> 1. seqpacket_allow is not initialized when socket is
> created. Thus if features are never set, it will be
> read uninitialized.
> 2. if VIRTIO_VSOCK_F_SEQPACKET is set and then cleared,
> then seqpacket_allow will not be cleared appropriately
> (existing apps I know about don't usually do this but
> it's legal and there's no way to be sure no one relies
> on this).
>
> To fix:
> - initialize seqpacket_allow after allocation
> - set it unconditionally in set_features
>
> Reported-by: syzbot+6c21aeb59d0e82eb2782@...kaller.appspotmail.com
> Reported-by: Jeongjun Park <aha310510@...il.com>
> Fixes: ced7b713711f ("vhost/vsock: support SEQPACKET for transport").
> Cc: Arseny Krasnov <arseny.krasnov@...persky.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> Acked-by: Arseniy Krasnov <avkrasnov@...utedevices.com>
> Tested-by: Arseniy Krasnov <avkrasnov@...utedevices.com>
>
Acked-by: Jason Wang <jasowang@...hat.com>
Thanks
Powered by blists - more mailing lists