linux-kernel - Re: [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ed5326a-b2ea-220a-2a9b-0478df0c6f12@quicinc.com>
Date: Thu, 16 May 2024 10:51:22 +0530
From: Naina Mehta <quic_nainmeht@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <ulf.hansson@...aro.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <bhupesh.sharma@...aro.org>
CC: <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card



On 5/15/2024 7:53 PM, Krzysztof Kozlowski wrote:
> On 15/05/2024 14:09, Naina Mehta wrote:
>> Enable SDHCI on sdx75-idp to support SD card.
>> Also add the required regulators.
>>
>> Signed-off-by: Naina Mehta <quic_nainmeht@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75-idp.dts | 45 ++++++++++++++++++++++++++
>>   1 file changed, 45 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> index f76e72fb2072..6f94278cf837 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>> @@ -41,6 +41,29 @@
>>
>>   		vin-supply = <&vph_ext>;
>>   	};
>> +
>> +	vreg_sd_vccb: sd-vccb {
> 
> Please use name for all fixed regulators which matches current format
> recommendation: 'regulator-[0-9]+v[0-9]+'

Did you mean that vreg_sd_vdd should be updated according to the 
suggested format because vreg_sd_vccb is not a fixed regulator?

Thanks,
Naina

> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=b6d4b3500d57370f5b3abf0701c9166b384db976
> 
> 
> Best regards,
> Krzysztof
>