linux-kernel - Re: [PATCH v2] mm/huge_memory: don't unpoison huge_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZkXMuHcWPBXy9sT3@localhost.localdomain>
Date: Thu, 16 May 2024 11:07:04 +0200
From: Oscar Salvador <osalvador@...e.de>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: David Hildenbrand <david@...hat.com>, akpm@...ux-foundation.org,
	shy828301@...il.com, nao.horiguchi@...il.com,
	xuyu@...ux.alibaba.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/huge_memory: don't unpoison huge_zero_folio

On Thu, May 16, 2024 at 04:45:22PM +0800, Miaohe Lin wrote:
> Thanks for your comment. Do you mean something like below?
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 16ada4fb02b7..a9fe9eda593f 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -2546,6 +2546,13 @@ int unpoison_memory(unsigned long pfn)
>                 goto unlock_mutex;
>         }
> 
> +       if (is_huge_zero_folio(folio)) {
> +               unpoison_pr_info("Unpoison: huge zero page is not supported %#lx\n",
> +                                pfn, &unpoison_rs);
> +               ret = -EOPNOTSUPP;
> +               goto unlock_mutex;
> +       }
> +
>         if (!PageHWPoison(p)) {
>                 unpoison_pr_info("Unpoison: Page was already unpoisoned %#lx\n",
>                                  pfn, &unpoison_rs);

Yes, something like that makes much more sense to me.


Thanks

-- 
Oscar Salvador
SUSE Labs