linux-kernel - Re: [PATCH net] net: prevent pulling SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 16 May 2024 08:11:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Lena Wang (王娜)" <Lena.Wang@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Shiming
 Cheng (成诗明)" <Shiming.Cheng@...iatek.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "willemdebruijn.kernel@...il.com"
 <willemdebruijn.kernel@...il.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "matthias.bgg@...il.com"
 <matthias.bgg@...il.com>, "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb

On Wed, 15 May 2024 09:02:35 +0000 Lena Wang (王娜) wrote:
> > One of the fixes you posted breaks the
> > 
> >   tools/testing/selftests/net/udpgro_fwd.sh
> > 
> > selftest. Please investigate, and either adjust the test or the fix.  
> 
> Dear Jakub,
> Sorry for late response.
> As we do not make selftest before, I try to build a test environmen and
> cost time to apply sudo access right in our company server.

Please read:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style

Depending on your setup sudo may not be needed.

> Now it blocks to generate xdp_dummy.bpf.o. Could you please give some guidline
> about the script test step? Thanks.

Install clang and run make? Please share some outputs or more details,
I'm not sure what the problem is

> Could you give more info about the failed situation?  
> Is it this fix "[PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb"
> failed?
> Which case is failed?

These are the results, as far as I can tell:

https://netdev-3.bots.linux.dev/vmksft-net/results/573200/24-udpgro-fwd-sh/

> Is it possible that the test case has issue?

Entirely possible, yes.