linux-kernel - Re: [PATCH net] net: prevent pulling SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 10:03:55 +0000
From: Lena Wang (王娜) <Lena.Wang@...iatek.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Shiming Cheng (成诗明)
	<Shiming.Cheng@...iatek.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb

On Thu, 2024-05-16 at 08:11 -0700, Jakub Kicinski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, 15 May 2024 09:02:35 +0000 Lena Wang (王娜) wrote:
> > > One of the fixes you posted breaks the
> > > 
> > >   tools/testing/selftests/net/udpgro_fwd.sh
> > > 
> > > selftest. Please investigate, and either adjust the test or the
> fix.  
> > 
> > Dear Jakub,
> > Sorry for late response.
> > As we do not make selftest before, I try to build a test environmen
> and
> > cost time to apply sudo access right in our company server.
> 
> Please read:
> 
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
> 
> Depending on your setup sudo may not be needed.
> 
> > Now it blocks to generate xdp_dummy.bpf.o. Could you please give
> some guidline
> > about the script test step? Thanks.
> 
> Install clang and run make? Please share some outputs or more
> details,
> I'm not sure what the problem is
> 
> > Could you give more info about the failed situation?  
> > Is it this fix "[PATCH net] net: prevent pulling SKB_GSO_FRAGLIST
> skb"
> > failed?
> > Which case is failed?
> 
> These are the results, as far as I can tell:
> 
> 
https://netdev-3.bots.linux.dev/vmksft-net/results/573200/24-udpgro-fwd-sh/
> 
> > Is it possible that the test case has issue?
> 
> Entirely possible, yes.

Dear Jakub,
Thanks your guidence.
I have set up the test environment and part of test cases could pass.

The problem now is the ethtool in ubuntu can't support "rx-gro-list"
and "rx-udp-gro-forwarding" although it is updated to version 6.7 from 
https://mirrors.edge.kernel.org/pub/software/network/ethtool. 

There is another verison in 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ethtool.
 We download the sourcecode but don't know how to compile for ubuntu as
no ./configure there.

Is it the one we should use?  If yes, could you please show me how to
compile and install this ethtool?

Below are my test result with current ethtool now:

IPv4
No GRO                                   ok
ethtool: bad command line argument(s)
For more information run ethtool -h
GRO frag list                            fail - received 10 packets,
expected 1
./udpgro_fwd.sh: line 231: rx-udp-gro-forwarding: command not found
GRO fwd                                  fail - received 10 packets,
expected 1
UDP fwd perf                            udp rx:     77 MB/s    63024
calls/s
udp tx:   2099 MB/s    35603 calls/s  35603 msg/s
udp rx:     89 MB/s    73011 calls/s
udp tx:   2090 MB/s    35459 calls/s  35459 msg/s
udp rx:     82 MB/s    66799 calls/s
udp tx:   2100 MB/s    35621 calls/s  35621 msg/s
./udpgro_fwd.sh: line 239: rx-udp-gro-forwarding: command not found
UDP GRO fwd perf                        udp rx:     47 MB/s    39052
calls/s
udp tx:   1654 MB/s    28059 calls/s  28059 msg/s
udp rx:     71 MB/s    58102 calls/s
udp tx:   1932 MB/s    32774 calls/s  32774 msg/s
udp rx:     85 MB/s    69976 calls/s
udp tx:   2094 MB/s    35524 calls/s  35524 msg/s
./udpgro_fwd.sh: line 244: rx-gro-list: command not found
GRO frag list over UDP tunnel            fail - received 10 packets,
expected 1
./udpgro_fwd.sh: line 251: rx-udp-gro-forwarding: command not found
GRO fwd over UDP tunnel                  fail - received 10 packets,
expected 1
UDP tunnel fwd perf                     udp rx:     45 MB/s    37075
calls/s
udp tx:   1070 MB/s    18149 calls/s  18149 msg/s
udp rx:     55 MB/s    45396 calls/s
udp tx:   1070 MB/s    18159 calls/s  18159 msg/s
udp rx:     55 MB/s    45032 calls/s
udp tx:   1075 MB/s    18233 calls/s  18233 msg/s
./udpgro_fwd.sh: line 263: rx-udp-gro-forwarding: command not found
UDP tunnel GRO fwd perf                 udp rx:     45 MB/s    37440
calls/s
udp tx:   1065 MB/s    18078 calls/s  18078 msg/s
udp rx:     70 MB/s    57512 calls/s
udp tx:   1066 MB/s    18091 calls/s  18091 msg/s
udp rx:     68 MB/s    55432 calls/s
udp tx:   1067 MB/s    18110 calls/s  18110 msg/s

Thanks
Lena