[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <124b75a6-d8da-4e29-8dce-79d18c355ba2@foss.st.com>
Date: Fri, 17 May 2024 08:11:50 +0200
From: Patrice CHOTARD <patrice.chotard@...s.st.com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
Linus Walleij
<linus.walleij@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Dvorkin Dmitry <dvorkin@...bo.com>, Wells Lu <wellslutw@...il.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Emil Renner Berthing
<kernel@...il.dk>,
Jianlong Huang <jianlong.huang@...rfivetech.com>,
Hal Feng
<hal.feng@...rfivetech.com>,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang
<baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
Viresh
Kumar <vireshk@...nel.org>,
Shiraz Hashim <shiraz.linux.kernel@...il.com>, <soc@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Sylwester Nawrocki
<s.nawrocki@...sung.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Geert
Uytterhoeven <geert+renesas@...der.be>,
Heiko Stuebner <heiko@...ech.de>, Damien Le Moal <dlemoal@...nel.org>,
Ludovic Desroches
<ludovic.desroches@...rochip.com>,
Nicolas Ferre
<nicolas.ferre@...rochip.com>,
Alexandre Belloni
<alexandre.belloni@...tlin.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Dong Aisheng <aisheng.dong@....com>,
Fabio Estevam <festevam@...il.com>, Shawn Guo <shawnguo@...nel.org>,
Jacky Bai <ping.bai@....com>,
Pengutronix
Kernel Team <kernel@...gutronix.de>,
Chester Lin <chester62515@...il.com>,
Matthias Brugger <mbrugger@...e.com>,
Ghennadi Procopciuc
<ghennadi.procopciuc@....nxp.com>,
Sean Wang <sean.wang@...nel.org>,
Matthias
Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Sascha Hauer
<s.hauer@...gutronix.de>,
Andrew Jeffery <andrew@...econstruct.com.au>,
Joel
Stanley <joel@....id.au>,
Dan Carpenter <dan.carpenter@...aro.org>,
Tony
Lindgren <tony@...mide.com>,
Stephen Warren <swarren@...dotorg.org>
CC: <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-tegra@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-samsung-soc@...r.kernel.org>,
<linux-renesas-soc@...r.kernel.org>,
<linux-rockchip@...ts.infradead.org>,
<linux-riscv@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>, <imx@...ts.linux.dev>,
<linux-aspeed@...ts.ozlabs.org>, <openbmc@...ts.ozlabs.org>,
Peng Fan
<peng.fan@....com>
Subject: Re: [PATCH v2 03/20] pinctrl: stm32: Use scope based of_node_put()
cleanups
On 5/4/24 15:20, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
>
> Use scope based of_node_put() cleanup to simplify code.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index 978ccdbaf3d3..a8673739871d 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -670,7 +670,6 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> struct device_node *np_config,
> struct pinctrl_map **map, unsigned *num_maps)
> {
> - struct device_node *np;
> unsigned reserved_maps;
> int ret;
>
> @@ -678,12 +677,11 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> *num_maps = 0;
> reserved_maps = 0;
>
> - for_each_child_of_node(np_config, np) {
> + for_each_child_of_node_scoped(np_config, np) {
> ret = stm32_pctrl_dt_subnode_to_map(pctldev, np, map,
> &reserved_maps, num_maps);
> if (ret < 0) {
> pinctrl_utils_free_map(pctldev, *map, *num_maps);
> - of_node_put(np);
> return ret;
> }
> }
>
Hi
Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>
Thanks
Patrice
Powered by blists - more mailing lists