linux-kernel - Re: [PATCH printk v5 10/30] console: Improve console_srcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 17 May 2024 16:55:25 +0200
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH printk v5 10/30] console: Improve
 console_srcu_read_flags() comments

On Thu 2024-05-02 23:44:19, John Ogness wrote:
> It was not clear when exactly console_srcu_read_flags() must be
> used vs. directly reading @console->flags.
> 
> Refactor and clarify that console_srcu_read_flags() is only
> needed if the console is registered or the caller is in a
> context where the registration status of the console may change
> (due to another context).
> 
> The function requires the caller holds @console_srcu, which will
> ensure that the caller sees an appropriate @flags value for the
> registered console and that exit/cleanup routines will not run
> if the console is in the process of unregistration.
> 
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

Sounds good:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr