linux-kernel - Re: clang: arch/x86/boot/printf.c:257:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240517145655.GA3660288@thelio-3990X>
Date: Fri, 17 May 2024 07:56:55 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: open list <linux-kernel@...r.kernel.org>, lkft-triage@...ts.linaro.org,
	clang-built-linux <llvm@...ts.linux.dev>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Anders Roxell <anders.roxell@...aro.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Borislav Petkov <bp@...e.de>, Borislav Petkov <bp@...en8.de>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: clang: arch/x86/boot/printf.c:257:3: error: unannotated
 fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

Hi Naresh,

On Fri, May 17, 2024 at 01:00:25PM +0200, Naresh Kamboju wrote:
> The following x86 build failed on Linux next-20240517 tag due to following
> warnings / errors only seen with clang builds.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> 
> Build errors:
> ----
> arch/x86/boot/printf.c:257:3: error: unannotated fall-through between
> switch labels [-Werror,-Wimplicit-fallthrough]
>   257 |                 case 'u':
>       |                 ^
> arch/x86/boot/printf.c:257:3: note: insert 'break;' to avoid fall-through
>   257 |                 case 'u':
>       |                 ^
>       |                 break;
> 1 error generated.
> 
> The suspected patch,
> x86/boot: Add a fallthrough annotation

Thanks for the report, this has been addressed:

https://git.kernel.org/tip/82110ae235e0560d1f952f74f9fd991587b0e3a7

Cheers,
Nathan