linux-kernel - Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 17 May 2024 13:53:47 -0700
From: Daniel Latypov <dlatypov@...gle.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Devarsh Thakkar <devarsht@...com>, mchehab@...nel.org, hverkuil-cisco@...all.nl, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	benjamin.gaignard@...labora.com, sebastian.fricke@...labora.com, 
	akpm@...ux-foundation.org, gregkh@...uxfoundation.org, adobriyan@...il.com, 
	jani.nikula@...el.com, p.zabel@...gutronix.de, airlied@...il.com, 
	daniel@...ll.ch, dri-devel@...ts.freedesktop.org, 
	laurent.pinchart@...asonboard.com, praneeth@...com, nm@...com, 
	vigneshr@...com, a-bhatia1@...com, j-luthra@...com, b-brnich@...com, 
	detheridge@...com, p-mantena@...com, vijayp@...com, andrzej.p@...labora.com, 
	nicolas@...fresne.ca, davidgow@...gle.com
Subject: Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> > [devarsht: Rebase to 6.9 and change license to GPL]
>
> I'm not sure that you may change license. It needs the author's confirmation.

Checking, this is referring to the MODULE_LICENSE, which used to be
MODULE_LICENSE("GPL v2");

and is now
MODULE_LICENSE("GPL");

If checkpatch is suggesting that now, then changing it sounds good to me.

>
> > ---
> > Changes since v6:
> > * Rebase to linux-next, change license to GPL as suggested by checkpatch.
>
> Note, checkpatch.pl is not false positives free. Be careful
> with what it suggests.
>
> > +#include <kunit/test.h>
> > +#include <linux/gcd.h>
>
> > +#include <linux/kernel.h>
>
> Do you know why this header is included?

I think I had put it in the original before a lot of the work you did
to split things out of kernel.h.
I haven't had time to look apply this patch series locally yet, but
I'd be pretty sure we can remove it without anything breaking.

Thanks,
Daniel