[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240519185405.30dce3aa@jic23-huawei>
Date: Sun, 19 May 2024 18:54:05 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Alisa-Dariana Roman <alisadariana@...il.com>
Cc: michael.hennerich@...log.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, lars@...afoo.de,
robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org,
nuno.sa@...log.com, marcelo.schmitt@...log.com, bigunclemax@...il.com,
dlechner@...libre.com, okan.sahin@...log.com, fr0st61te@...il.com,
alisa.roman@...log.com, marcus.folkesson@...il.com, schnelle@...ux.ibm.com,
liambeguin@...il.com
Subject: Re: [PATCH v8 2/6] dt-bindings: iio: adc: ad7192: Add aincom supply
On Tue, 14 May 2024 15:02:18 +0300
Alisa-Dariana Roman <alisadariana@...il.com> wrote:
> AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
> in pseudo-differential operation mode. AINCOM voltage represents the
> offset of corresponding channels.
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
Whilst I'm not sure we've totally bottomed out on how to describe
all combinations of pseudo-differential this seem reasonable for this
particular device and harmless against any proposals we have had so far.
Hence applied.
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> index 16def2985ab4..cf5c568f140a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> @@ -41,6 +41,11 @@ properties:
> interrupts:
> maxItems: 1
>
> + aincom-supply:
> + description: |
> + AINCOM voltage supply. Analog inputs AINx are referenced to this input
> + when configured for pseudo-differential operation.
> +
> dvdd-supply:
> description: DVdd voltage supply
>
> @@ -117,6 +122,7 @@ examples:
> clock-names = "mclk";
> interrupts = <25 0x2>;
> interrupt-parent = <&gpio>;
> + aincom-supply = <&aincom>;
> dvdd-supply = <&dvdd>;
> avdd-supply = <&avdd>;
> vref-supply = <&vref>;
Powered by blists - more mailing lists