linux-kernel - Re: [PATCH v5 1/1] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 20 May 2024 01:57:12 +0800
From: kernel test robot <lkp@...el.com>
To: Baojun Xu <baojun.xu@...com>, tiwai@...e.de
Cc: oe-kbuild-all@...ts.linux.dev, robh+dt@...nel.org,
	andriy.shevchenko@...ux.intel.com, lgirdwood@...il.com,
	perex@...ex.cz, pierre-louis.bossart@...ux.intel.com,
	kevin-lu@...com, shenghao-ding@...com, navada@...com,
	13916275206@....com, v-po@...com, niranjan.hy@...com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, yung-chuan.liao@...ux.intel.com,
	baojun.xu@...com, broonie@...nel.org, soyer@....hu
Subject: Re: [PATCH v5 1/1] ALSA: hda/tas2781: Add tas2781 hda driver based
 on SPI

Hi Baojun,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus rafael-pm/linux-next rafael-pm/bleeding-edge linus/master v6.9 next-20240517]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Baojun-Xu/ALSA-hda-tas2781-Add-tas2781-hda-driver-based-on-SPI/20240519-230843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20240519150433.760-2-baojun.xu%40ti.com
patch subject: [PATCH v5 1/1] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240520/202405200105.BWxmtco7-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240520/202405200105.BWxmtco7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405200105.BWxmtco7-lkp@intel.com/

All warnings (new ones prefixed by >>):

   sound/pci/hda/tas2781_hda_spi.c: In function 'tas2781_runtime_suspend':
>> sound/pci/hda/tas2781_hda_spi.c:1124:16: warning: unused variable 'ret' [-Wunused-variable]
    1124 |         int i, ret;
         |                ^~~
>> sound/pci/hda/tas2781_hda_spi.c:1124:13: warning: unused variable 'i' [-Wunused-variable]
    1124 |         int i, ret;
         |             ^
   sound/pci/hda/tas2781_hda_spi.c: In function 'tas2781_runtime_resume':
   sound/pci/hda/tas2781_hda_spi.c:1143:16: warning: unused variable 'ret' [-Wunused-variable]
    1143 |         int i, ret;
         |                ^~~
   sound/pci/hda/tas2781_hda_spi.c:1143:13: warning: unused variable 'i' [-Wunused-variable]
    1143 |         int i, ret;
         |             ^


vim +/ret +1124 sound/pci/hda/tas2781_hda_spi.c

  1120	
  1121	static int tas2781_runtime_suspend(struct device *dev)
  1122	{
  1123		struct tas2781_hda *tas_hda = dev_get_drvdata(dev);
> 1124		int i, ret;
  1125	
  1126		guard(mutex)(&tas_hda->priv->codec_lock);
  1127	
  1128		if (tas_hda->priv->playback_started) {
  1129			tasdevice_spi_tuning_switch(tas_hda->priv, 1);
  1130			tas_hda->priv->playback_started = false;
  1131		}
  1132	
  1133		tas_hda->priv->cur_book = -1;
  1134		tas_hda->priv->cur_prog = -1;
  1135		tas_hda->priv->cur_conf = -1;
  1136	
  1137		return 0;
  1138	}
  1139	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki