linux-kernel - Re: [PATCH v8 6/6] iio: adc: ad7192: Add AD7194 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240520132030.00000838@Huawei.com>
Date: Mon, 20 May 2024 13:20:30 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Alisa-Dariana Roman <alisadariana@...il.com>
CC: Jonathan Cameron <jic23@...nel.org>, Andy Shevchenko <andy@...nel.org>,
	<michael.hennerich@...log.com>, <linux-iio@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lars@...afoo.de>, <robh@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
	<conor+dt@...nel.org>, <lgirdwood@...il.com>, <broonie@...nel.org>,
	<nuno.sa@...log.com>, <marcelo.schmitt@...log.com>, <bigunclemax@...il.com>,
	<dlechner@...libre.com>, <okan.sahin@...log.com>, <fr0st61te@...il.com>,
	<alisa.roman@...log.com>, <marcus.folkesson@...il.com>,
	<schnelle@...ux.ibm.com>, <liambeguin@...il.com>
Subject: Re: [PATCH v8 6/6] iio: adc: ad7192: Add AD7194 support

On Sun, 19 May 2024 22:37:58 +0300
Alisa-Dariana Roman <alisadariana@...il.com> wrote:

> On 19.05.2024 21:03, Jonathan Cameron wrote:
> > On Tue, 14 May 2024 16:09:32 +0300
> > Andy Shevchenko <andy@...nel.org> wrote:
> >   
> >> On Tue, May 14, 2024 at 03:02:22PM +0300, Alisa-Dariana Roman wrote:  
> >>> Unlike the other AD719Xs, AD7194 has configurable channels. The user can
> >>> dynamically configure them in the devicetree.
> >>>
> >>> Add sigma_delta_info member to chip_info structure. Since AD7194 is the
> >>> only chip that has no channel sequencer, num_slots should remain
> >>> undefined.
> >>>
> >>> Also modify config AD7192 description for better scaling.  
> >>
> >> Some non-critical, mostly style related comments below.
> >>  
> > Tweaked a bit. And applied.  Please check the result in the testing branch
> > of iio.git.  
> 
> Thank you guys for the feedback and for making the adjustments!
> 
> +/* 10th bit corresponds to CON18(Pseudo) */
> +#define AD7194_CH(p)		(BIT(10) | AD7194_CH_POS(p))
> +
> I noticed this comment got away in the testing branch.
> 
> 
> +static bool ad7194_validate_ain_channel(struct device *dev, u32 ain)
> +{
> +	return in_range(ain, AD7194_CH_AIN_START, AD7194_CH_AIN_NR);
> +}
> And the negation got lost here.

Ouch :( 

> 
> With these little changes, tested on board to make sure, running perfectly!
> 
To make sure I don't mess it up again, could you post the fix and I'll squash
it into the patch on the tree.

I blame caffeine (for no particularly reason ;)

Jonathan

> Kind regards,
> Alisa-Dariana Roman.
> 
>