linux-kernel - Re: [PATCH v8 6/6] iio: adc: ad7192: Add AD7194 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZktB5Ex5oQ2E45QR@smile.fi.intel.com>
Date: Mon, 20 May 2024 15:28:20 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Alisa-Dariana Roman <alisadariana@...il.com>,
	Jonathan Cameron <jic23@...nel.org>, michael.hennerich@...log.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, lars@...afoo.de, robh@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	lgirdwood@...il.com, broonie@...nel.org, nuno.sa@...log.com,
	marcelo.schmitt@...log.com, bigunclemax@...il.com,
	dlechner@...libre.com, okan.sahin@...log.com, fr0st61te@...il.com,
	alisa.roman@...log.com, marcus.folkesson@...il.com,
	schnelle@...ux.ibm.com, liambeguin@...il.com
Subject: Re: [PATCH v8 6/6] iio: adc: ad7192: Add AD7194 support

On Mon, May 20, 2024 at 01:20:30PM +0100, Jonathan Cameron wrote:
> On Sun, 19 May 2024 22:37:58 +0300
> Alisa-Dariana Roman <alisadariana@...il.com> wrote:
> > On 19.05.2024 21:03, Jonathan Cameron wrote:

..

> > +static bool ad7194_validate_ain_channel(struct device *dev, u32 ain)
> > +{
> > +	return in_range(ain, AD7194_CH_AIN_START, AD7194_CH_AIN_NR);
> > +}
> > And the negation got lost here.
> 
> Ouch :( 

And negation most likely should be on the caller's side.

-- 
With Best Regards,
Andy Shevchenko