linux-kernel - Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com>
Date: Mon, 20 May 2024 08:49:00 -0500
From: Carlos Bilbao <carlos.bilbao.osdev@...il.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Michael Roth <michael.roth@....com>, kvm@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-coco@...ts.linux.dev
Cc: LKML <linux-kernel@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
 Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling

Hey Markus,

On 5/19/24 12:50 AM, Markus Elfring wrote:
>> The variable 'sev' is assigned, but never used. Remove it.
> Would it be a bit nicer to use the word “Omit” instead of “Fix”
> in the summary phrase?


I can find many instances of "Fix unused variable" in the history of the
kernel:

ubsan: fix unused variable warning in test module
x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe()
octeontx2-pf: Fix unused variable build error
etc...

but not a single "Omit unused variable" commit.


>
> Regards,
> Markus


Thanks,
Carlos