linux-kernel - Re: KVM: SEV: Fix unused variable in guest request handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6da2ddfb-02f3-43a7-89f4-60d1613dd5a4@web.de>
Date: Mon, 20 May 2024 16:16:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Carlos Bilbao <carlos.bilbao.osdev@...il.com>,
 Michael Roth <michael.roth@....com>, kvm@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-coco@...ts.linux.dev
Cc: LKML <linux-kernel@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
 Sean Christopherson <seanjc@...gle.com>
Subject: Re: KVM: SEV: Fix unused variable in guest request handling

>>> The variable 'sev' is assigned, but never used. Remove it.
>> Would it be a bit nicer to use the word “Omit” instead of “Fix”
>> in the summary phrase?
>
>
> I can find many instances of "Fix unused variable" in the history of the
> kernel:
…
> but not a single "Omit unused variable" commit.

Some implementation details were fixed somehow because of a warning or error message.
You would probably like to point the desire out in your summary phrase
to get rid of another bit of redundant source code.

Were any analysis tools involved in the discovery of corresponding change possibilities?

Regards,
Markus