linux-kernel - Re: [PATCH] i2c: ocores: set IACK bit after core is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 20 May 2024 17:01:34 +0200
From: grygorii tertychnyi <grembeter@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Markus Elfring <Markus.Elfring@....de>, 
	Grygorii Tertychnyi <grygorii.tertychnyi@...ca-geosystems.com>, 
	bsp-development.geo@...ca-geosystems.com, linux-i2c@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, Peter Korsgaard <peter@...sgaard.com>, 
	Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled

On Mon, May 20, 2024 at 3:41 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote:
> > On Sun, May 19, 2024 at 7:25 AM Markus Elfring <Markus.Elfring@....de> wrote:
> > >
> > > …
> > > > Sometimes it causes failure for the very first message transfer, …
> > >
> > > Does such an information indicate the need for the tag “Fixes”?
> >
> > I'm not sure: the original initialization order was introduced by the
> > very first commit
> > 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller").
>
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
>   It fixes a problem like an oops, a hang, data corruption, a real
>   security issue, a hardware quirk, a build error (but not for things
>   marked CONFIG_BROKEN), or some “oh, that’s not good” issue.
>
> Your description of the very first message transfer failing sounds
> like a data corruption? Using the commit which adds the driver is also
> fine, some bugs have been there all the time.

Thanks! Yes, it is a data corruption.

> Remember to add a
>
> Cc: stable@...r.kernel.org

I will send v2.

Regards,
Grygorii