linux-kernel - Re: [PATCH] i2c: ocores: set IACK bit after core is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a42d75ad-8065-49f0-906a-c8ae3761457c@lunn.ch>
Date: Mon, 20 May 2024 15:41:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: grygorii tertychnyi <grembeter@...il.com>
Cc: Markus Elfring <Markus.Elfring@....de>,
	Grygorii Tertychnyi <grygorii.tertychnyi@...ca-geosystems.com>,
	bsp-development.geo@...ca-geosystems.com, linux-i2c@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Peter Korsgaard <peter@...sgaard.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled

On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote:
> On Sun, May 19, 2024 at 7:25 AM Markus Elfring <Markus.Elfring@....de> wrote:
> >
> > …
> > > Sometimes it causes failure for the very first message transfer, …
> >
> > Does such an information indicate the need for the tag “Fixes”?
> 
> I'm not sure: the original initialization order was introduced by the
> very first commit
> 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller").

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

  It fixes a problem like an oops, a hang, data corruption, a real
  security issue, a hardware quirk, a build error (but not for things
  marked CONFIG_BROKEN), or some “oh, that’s not good” issue.

Your description of the very first message transfer failing sounds
like a data corruption? Using the commit which adds the driver is also
fine, some bugs have been there all the time.

Remember to add a

Cc: stable@...r.kernel.org

    Andrew