[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZkvErLsj8Ngj4qM3@casper.infradead.org>
Date: Mon, 20 May 2024 22:46:20 +0100
From: Matthew Wilcox <willy@...radead.org>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
Cc: linux-mm@...ck.org, akpm@...ux-foundation.org, muchun.song@...ux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Convert __unmap_hugepage_range() to folios
On Mon, May 20, 2024 at 12:47:49PM -0700, Vishal Moola (Oracle) wrote:
> Replaces 4 calls to compound_head() with one. Also converts
> unmap_hugepage_range() and unmap_ref_private() to take in folios.
This is great!
> void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> unsigned long start, unsigned long end,
> - struct page *ref_page, zap_flags_t zap_flags)
> + struct folio *ref_folio, zap_flags_t zap_flags)
> {
> struct mm_struct *mm = vma->vm_mm;
> unsigned long address;
> pte_t *ptep;
> pte_t pte;
> spinlock_t *ptl;
> - struct page *page;
> + struct folio *folio;
> struct hstate *h = hstate_vma(vma);
> unsigned long sz = huge_page_size(h);
I would appreciate some further cleanup ...
size_t sz = folio_size(folio);
I think there are further cleanups along those lines, eg
pages_per_huge_page(), hugetlb_mask_last_page(), huge_page_mask().
Powered by blists - more mailing lists