linux-kernel - Re: [PATCH 1/5] dt-bindings: trivial-devices: Drop adi,adp5585 and adi,adp5585-02

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 21 May 2024 22:44:31 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org,
	Alexandru Ardelean <alexandru.ardelean@...log.com>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Lee Jones <lee@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Uwe Kleine-König <ukleinek@...nel.org>
Subject: Re: [PATCH 1/5] dt-bindings: trivial-devices: Drop adi,adp5585 and
 adi,adp5585-02

On Tue, May 21, 2024 at 09:02:19PM +0200, Krzysztof Kozlowski wrote:
> On 20/05/2024 21:59, Laurent Pinchart wrote:
> > The Analog Devices ADP5585 is a multi-function device that requires
> > non-trivial DT bindings. To prepare for proper support of the device,
> > drop the related compatible strings from trivial-devices.yaml. They were
> > added by mistake, without any user in the mainline kernel, neither in
> > device tree sources nor in drivers.
> > 
> > Fixes: e5dddbedfe09 ("dt-bindings: add ADP5585/ADP5589 entries to trivial-devices")
> 
> I don't see a bug there. Just because there are no users, it is not yet
> a bug.

The bug (as I see it) is that compatible strings were added to the list
of trivial devices when then patch series that did so did not intend
those compatible strings to be used by anything.

> This should be squashed with next patch so you keep compatibles documented.

I'm fine with that.

-- 
Regards,

Laurent Pinchart