linux-kernel - R rtc-ab-eoz9.c alarm hours work only between 00:00

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Tue, 21 May 2024 07:00:57 +0000
From: Erkkilä Taneli <Taneli.Erkkila@...c.fi>
To: "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC: "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: R rtc-ab-eoz9.c alarm hours work only between 00:00 - 19:59

Driver uses only first 4 bits from "alarm hour"(ABEOZ9_BIT_ALARM_HOURS) that makes it work only between 00:00-19:59. Fifth bit tells alarm time between 20:00-23:59 and it is ignored.


Index: linux-imx/drivers/rtc/rtc-ab-eoz9.c
===================================================================
--- linux-imx.orig/drivers/rtc/rtc-ab-eoz9.c
+++ linux-imx/drivers/rtc/rtc-ab-eoz9.c
@@ -64,7 +64,7 @@
#define ABEOZ9_BIT_ALARM_MIN                                             GENMASK(6, 0)
#define ABEOZ9_REG_ALARM_HOURS                                      0x12
#define ABEOZ9_BIT_ALARM_HOURS_PM  BIT(5)
-#define ABEOZ9_BIT_ALARM_HOURS                                       GENMASK(4, 0)
+#define ABEOZ9_BIT_ALARM_HOURS                                      GENMASK(5, 0)
#define ABEOZ9_REG_ALARM_DAYS                                          0x13
#define ABEOZ9_BIT_ALARM_DAYS                                            GENMASK(5, 0)
#define ABEOZ9_REG_ALARM_WEEKDAYS  0x14