linux-kernel - Re: [PATCH 01/13] a2b: add A2B driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024052125-washroom-hardened-820a@gregkh>
Date: Tue, 21 May 2024 09:37:31 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Alvin Šipraga <ALSI@...g-olufsen.dk>,
	devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-clk@...r.kernel.org, kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Alvin Šipraga <alvin@...s.dk>,
	Emil Abildgaard Svendsen <EMAS@...g-olufsen.dk>,
	Andi Shyti <andi.shyti@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Conor Dooley <conor+dt@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mark Brown <broonie@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Stephen Boyd <sboyd@...nel.org>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 01/13] a2b: add A2B driver core

On Tue, May 21, 2024 at 09:33:51AM +0200, Markus Elfring wrote:
> >> …
> >>> +++ b/drivers/a2b/a2b.c
> >>> @@ -0,0 +1,1252 @@
> >> …
> >>> +static int a2b_bus_of_add_node(struct a2b_bus *bus, struct device_node *np,
> >>> +                            unsigned int addr)
> >>> +{
> >> …
> >>> +     node = kzalloc(sizeof(*node), GFP_KERNEL);
> >>> +     if (IS_ERR(node))
> >>> +             return -ENOMEM;
> >>
> >> Please improve the distinction for checks according to the handling of error/null pointers.
> >
> > Right, I think it returns NULL on error.
> 
> Do you see possibilities to reduce “confusion” about the properties of such a programming interface
> any further?
> https://elixir.bootlin.com/linux/v6.9.1/A/ident/kzalloc


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot