linux-kernel - Re: [PATCH 03/13] dt-bindings: a2b: Analog Devices AD24xx devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473dbd64-5479-47e0-9e5f-b0f623456b38@kernel.org>
Date: Tue, 21 May 2024 09:47:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc: Alvin Šipraga <alvin@...s.dk>,
 Mark Brown <broonie@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Liam Girdwood <lgirdwood@...il.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>,
 Emil Abildgaard Svendsen <EMAS@...g-olufsen.dk>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH 03/13] dt-bindings: a2b: Analog Devices AD24xx devices

On 21/05/2024 09:24, Alvin Šipraga wrote:

>>> +
>>> +required:
>>> +  - compatible
>>> +
>>> +unevaluatedProperties: false
>>
>> Sorry, but not. No resources, nothing here. Do not create bindings just
>> to instantiate drivers.
> 
> Do you mean that there is no need to introduce a binding for this codec
> if it has the same bindings as dai-common.yaml?

No, I said you do not have absolutely any resources here, so your
binding is empty. There is no need for such binding. You just want to
treat DT as way to instantiate drivers, which is a no-go.

> 
> Basically that is the case, but #sound-dai-cells should be <0>. Is that
> not enough?
> 
> I am OK to just drop the binding if you think so, but I would think that
> the compatible string should be somewhere in the bindings. Could you
> explain a little more what you mean?

Why do you need compatible? Which piece of hardware, with its own
resources, is being described here?

Just put dai-cells in parent node.

..

>>> +
>>> +examples:
>>> +  - |
>>> +    sync_clk: sync-clock {
>>
>> Drop, not related.
> 
> If the clock is required (as it is) then I have to reference some
> phandle in the example, 

Why?

> else the example will fail the check (missing
> required property 'clocks'). That's why I put it here. Please advise.

Let me answer indirectly: do you see any binding doing this? No. There
is almost none, so this should be a hint that it is not needed.

Best regards,
Krzysztof