linux-kernel - Re: [PATCH 1/1] dt-bindings: fsl-qdma: Convert to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a0e5863-27f7-47e4-9325-a686d5adffec@kernel.org>
Date: Tue, 21 May 2024 10:26:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Vinod Koul <vkoul@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
 <dmaengine@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: fsl-qdma: Convert to yaml format

On 20/05/2024 22:39, Frank Li wrote:
> Convert binding doc from txt to yaml.
> 
> Re-order interrupt-names to align example.


> +properties:
> +  compatible:
> +    enum:
> +      - fsl,ls1021a-qdma
> +      - fsl,ls1028a-qdma
> +      - fsl,ls1043a-qdma
> +      - fsl,ls1046a-qdma
> +
> +  reg:
> +    items:
> +      - description: Controller regs
> +      - description: Status regs
> +      - description: Block regs
> +
> +  interrupts:
> +    minItems: 2
> +    maxItems: 5
> +
> +  interrupt-names:
> +    minItems: 2
> +    items:
> +      - const: qdma-error
> +      - const: qdma-queue0
> +      - const: qdma-queue1
> +      - const: qdma-queue2
> +      - const: qdma-queue3
> +
> +  dma-channels:
> +    minItems: 1
> +    maxItems: 64

That's not a list. Did you just copy buggy fsl-edma?

> +
> +  fsl,dma-queues:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Should contain number of queues supported.

Constraints?

> +
> +  block-number:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: the virtual block number
> +
> +  block-offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: the offset of different virtual block
> +
> +  status-sizes:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: status queue size of per virtual block
> +
> +  queue-sizes:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      command queue size of per virtual block, the size number
> +      based on queues
> +
> +  big-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present registers and hardware scatter/gather descriptors
> +      of the qDMA are implemented in big endian mode, otherwise in little
> +      mode.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - fsl,dma-queues
> +  - block-number
> +  - block-offset
> +  - status-sizes
> +  - queue-sizes
> +
> +unevaluatedProperties: false
> +
> +allOf:
> +  - $ref: dma-controller.yaml#

This goes above unevaluatedProperties.

Please constrain interrupts per variant.


Best regards,
Krzysztof