linux-kernel - Re: [PATCH 2/4] LoongArch: smp: Add all CPUs enabled by fdt to NUMA node 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 24 May 2024 06:17:44 +0800
From: kernel test robot <lkp@...el.com>
To: Jiaxun Yang <jiaxun.yang@...goat.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Binbin Zhou <zhoubinbin@...ngson.cn>
Cc: oe-kbuild-all@...ts.linux.dev, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH 2/4] LoongArch: smp: Add all CPUs enabled by fdt to NUMA
 node 0

Hi Jiaxun,

kernel test robot noticed the following build errors:

[auto build test ERROR on 124cfbcd6d185d4f50be02d5f5afe61578916773]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiaxun-Yang/LoongArch-Fix-built-in-DTB-detection/20240522-041534
base:   124cfbcd6d185d4f50be02d5f5afe61578916773
patch link:    https://lore.kernel.org/r/20240521-loongarch-booting-fixes-v1-2-659c201c0370%40flygoat.com
patch subject: [PATCH 2/4] LoongArch: smp: Add all CPUs enabled by fdt to NUMA node 0
config: loongarch-randconfig-001-20240524 (https://download.01.org/0day-ci/archive/20240524/202405240627.5Ey7vV8v-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240524/202405240627.5Ey7vV8v-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405240627.5Ey7vV8v-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/loongarch/kernel/smp.c: In function 'fdt_smp_setup':
>> arch/loongarch/kernel/smp.c:287:17: error: implicit declaration of function 'set_cpuid_to_node'; did you mean 'set_cpu_numa_node'? [-Werror=implicit-function-declaration]
     287 |                 set_cpuid_to_node(cpuid, 0);
         |                 ^~~~~~~~~~~~~~~~~
         |                 set_cpu_numa_node
   cc1: some warnings being treated as errors


vim +287 arch/loongarch/kernel/smp.c

   259	
   260	static void __init fdt_smp_setup(void)
   261	{
   262	#ifdef CONFIG_OF
   263		unsigned int cpu, cpuid;
   264		struct device_node *node = NULL;
   265	
   266		for_each_of_cpu_node(node) {
   267			if (!of_device_is_available(node))
   268				continue;
   269	
   270			cpuid = of_get_cpu_hwid(node, 0);
   271			if (cpuid >= nr_cpu_ids)
   272				continue;
   273	
   274			if (cpuid == loongson_sysconf.boot_cpu_id) {
   275				cpu = 0;
   276			} else {
   277				cpu = cpumask_next_zero(-1, cpu_present_mask);
   278			}
   279	
   280			num_processors++;
   281			set_cpu_possible(cpu, true);
   282			set_cpu_present(cpu, true);
   283			__cpu_number_map[cpuid] = cpu;
   284			__cpu_logical_map[cpu] = cpuid;
   285	
   286			early_numa_add_cpu(cpu, 0);
 > 287			set_cpuid_to_node(cpuid, 0);
   288			numa_add_cpu(cpu);
   289		}
   290	
   291		loongson_sysconf.nr_cpus = num_processors;
   292		set_bit(0, loongson_sysconf.cores_io_master);
   293	#endif
   294	}
   295	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki