| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 May 2024 00:48:02 +0000
From: "Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>
To: 'Dave Martin' <Dave.Martin@....com>, "x86@...nel.org" <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: James Morse <james.morse@....com>, Fenghua Yu <fenghua.yu@...el.com>,
Reinette Chatre <reinette.chatre@...el.com>, Thomas Gleixner
<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
<bp@...en8.de>, H Peter Anvin <hpa@...or.com>, Babu Moger
<Babu.Moger@....com>, "shameerali.kolothum.thodi@...wei.com"
<shameerali.kolothum.thodi@...wei.com>, D Scott Phillips OS
<scott@...amperecomputing.com>, "carl@...amperecomputing.com"
<carl@...amperecomputing.com>, "lcherian@...vell.com" <lcherian@...vell.com>,
"bobo.shaobowang@...wei.com" <bobo.shaobowang@...wei.com>,
"baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>, Jamie Iles
<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>, Peter Newman
<peternewman@...gle.com>, "dfustini@...libre.com" <dfustini@...libre.com>,
"amitsinght@...vell.com" <amitsinght@...vell.com>, David Hildenbrand
<david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>
Subject: RE: [PATCH v2 06/35] x86/resctrl: Export resctrl fs's init function
Hello Dave, James
I think there is no problem.
Reviewed-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> From: James Morse <james.morse@....com>
>
> rdtgroup_init() needs exporting so that arch code can call it once it lives in core
> code. As this is one of the few functions exported, rename it to have "resctrl" in
> the name. The same goes for the exit call.
>
> x86's arch code init functions for RDT are renamed to have an arch prefix to
> make it clear these are part of the architecture code.
>
> Signed-off-by: James Morse <james.morse@....com>
> Signed-off-by: Dave Martin <Dave.Martin@....com>
>
> ---
>
> Changes in v2:
>
> * Rename stale rdtgroup_init() to resctrl_init() in
> arch/x86/kernel/cpu/resctrl/monitor.c comments.
>
> No functional change.
>
> * [Commit message only] Minor rewording to avoid "impersonating code".
>
> * [Commit message only] Typo fix:
> s/to have the resctrl/to have resctrl/ in commit message.
> ---
> arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++------
> arch/x86/kernel/cpu/resctrl/internal.h | 3 ---
> arch/x86/kernel/cpu/resctrl/monitor.c | 2 +-
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 8 ++++----
> include/linux/resctrl.h | 3 +++
> 5 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c
> b/arch/x86/kernel/cpu/resctrl/core.c
> index d07eff7d6750..b4e7d655e242 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -938,7 +938,7 @@ void resctrl_cpu_detect(struct cpuinfo_x86 *c)
> }
> }
>
> -static int __init resctrl_late_init(void)
> +static int __init resctrl_arch_late_init(void)
> {
> struct rdt_resource *r;
> int state, ret;
> @@ -963,7 +963,7 @@ static int __init resctrl_late_init(void)
> if (state < 0)
> return state;
>
> - ret = rdtgroup_init();
> + ret = resctrl_init();
> if (ret) {
> cpuhp_remove_state(state);
> return ret;
> @@ -979,18 +979,18 @@ static int __init resctrl_late_init(void)
> return 0;
> }
>
> -late_initcall(resctrl_late_init);
> +late_initcall(resctrl_arch_late_init);
>
> -static void __exit resctrl_exit(void)
> +static void __exit resctrl_arch_exit(void)
> {
> struct rdt_resource *r =
> &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>
> cpuhp_remove_state(rdt_online);
>
> - rdtgroup_exit();
> + resctrl_exit();
>
> if (r->mon_capable)
> rdt_put_mon_l3_config();
> }
>
> -__exitcall(resctrl_exit);
> +__exitcall(resctrl_arch_exit);
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
> b/arch/x86/kernel/cpu/resctrl/internal.h
> index 9048bd32e86f..7c073298aabf 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -300,9 +300,6 @@ extern struct list_head rdt_all_groups;
>
> extern int max_name_width, max_data_width;
>
> -int __init rdtgroup_init(void);
> -void __exit rdtgroup_exit(void);
> -
> /**
> * struct rftype - describe each file in the resctrl file system
> * @name: File name
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c
> b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 06565153ceb2..9f2fafcf78f1 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -941,7 +941,7 @@ static int dom_data_init(struct rdt_resource *r)
> /*
> * RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID
> are special and
> * are always allocated. These are used for the rdtgroup_default
> - * control group, which will be setup later in rdtgroup_init().
> + * control group, which will be setup later in resctrl_init().
> */
> idx = resctrl_arch_rmid_idx_encode(RESCTRL_RESERVED_CLOSID,
> RESCTRL_RESERVED_RMID);
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 871b59c2c886..997f31ee5de4 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -4118,14 +4118,14 @@ void resctrl_offline_cpu(unsigned int cpu) }
>
> /*
> - * rdtgroup_init - rdtgroup initialization
> + * resctrl_init - resctrl filesystem initialization
> *
> * Setup resctrl file system including set up root, create mount point,
> - * register rdtgroup filesystem, and initialize files under root directory.
> + * register resctrl filesystem, and initialize files under root directory.
> *
> * Return: 0 on success or -errno
> */
> -int __init rdtgroup_init(void)
> +int __init resctrl_init(void)
> {
> int ret = 0;
>
> @@ -4173,7 +4173,7 @@ int __init rdtgroup_init(void)
> return ret;
> }
>
> -void __exit rdtgroup_exit(void)
> +void __exit resctrl_exit(void)
> {
> debugfs_remove_recursive(debugfs_resctrl);
> unregister_filesystem(&rdt_fs_type);
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h index
> bf736ec22f71..de0297f6167a 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -336,4 +336,7 @@ void resctrl_arch_reset_rmid_all(struct rdt_resource *r,
> struct rdt_domain *d); extern unsigned int resctrl_rmid_realloc_threshold;
> extern unsigned int resctrl_rmid_realloc_limit;
>
> +int __init resctrl_init(void);
> +void __exit resctrl_exit(void);
> +
> #endif /* _RESCTRL_H */
> --
> 2.34.1
Powered by blists - more mailing lists