linux-kernel - [PATCH] sysfs: Unbreak the build around sysfs_bin_attr_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05f4290439a58730738a15b0c99cd8576c4aa0d9.1716461752.git.lukas@wunner.de>
Date: Thu, 23 May 2024 13:00:00 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>
Cc: Michael Ellerman <mpe@...erman.id.au>, linuxppc-dev@...ts.ozlabs.org, linux-acpi@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, Ard Biesheuvel <ardb@...nel.org>, linux-efi@...r.kernel.org, Zhenyu Wang <zhenyuw@...ux.intel.com>, Zhi Wang <zhi.wang.linux@...il.com>, intel-gvt-dev@...ts.freedesktop.org, Daniel Lezcano <daniel.lezcano@...aro.org>, linux-pm@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>, linux-modules@...r.kernel.org
Subject: [PATCH] sysfs: Unbreak the build around sysfs_bin_attr_simple_read()

Günter reports build breakage for m68k "m5208evb_defconfig" plus
CONFIG_BLK_DEV_INITRD=y caused by commit 66bc1a173328 ("treewide:
Use sysfs_bin_attr_simple_read() helper").

The defconfig disables CONFIG_SYSFS, so sysfs_bin_attr_simple_read()
is not compiled into the kernel.  But init/initramfs.c references
that function in the initializer of a struct bin_attribute.

Add an empty static inline to avoid the build breakage.

Fixes: 66bc1a173328 ("treewide: Use sysfs_bin_attr_simple_read() helper")
Reported-by: Guenter Roeck <linux@...ck-us.net>
Closes: https://lore.kernel.org/r/e12b0027-b199-4de7-b83d-668171447ccc@roeck-us.net
Signed-off-by: Lukas Wunner <lukas@...ner.de>
---
 include/linux/sysfs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index a7d725fbf739..c4e64dc11206 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -750,6 +750,15 @@ static inline int sysfs_emit_at(char *buf, int at, const char *fmt, ...)
 {
 	return 0;
 }
+
+static inline ssize_t sysfs_bin_attr_simple_read(struct file *file,
+						 struct kobject *kobj,
+						 struct bin_attribute *attr,
+						 char *buf, loff_t off,
+						 size_t count)
+{
+	return 0;
+}
 #endif /* CONFIG_SYSFS */

 static inline int __must_check sysfs_create_file(struct kobject *kobj,
-- 
2.43.0