linux-kernel - Re: [PATCH v1 2/2] spi: Check if transfer is mapped before calling DMA sync APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <424a8c56-bde0-4b49-ae16-a018fa1b4962@sirena.org.uk>
Date: Thu, 23 May 2024 13:01:41 +0100
From: Mark Brown <broonie@...nel.org>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 2/2] spi: Check if transfer is mapped before calling
 DMA sync APIs

On Wed, May 22, 2024 at 02:41:48PM -0400, Nícolas F. R. A. Prado wrote:

> I tested this series and I still get the oops (attached at the end for
> reference). When I tried this change originally, I added it on top of the
> patches you had supplied. And as it turns out one of them was necessary.
> Specifically, if I add 
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index f94420858c22..9bc9fd10d538 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1220,6 +1220,11 @@ void spi_unmap_buf(struct spi_controller *ctlr, struct device *dev,
>         spi_unmap_buf_attrs(ctlr, dev, sgt, dir, 0);

The other two patches are already queued, could you send this one
incrementally please Andy?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)