linux-kernel - Re: [PATCH] media: dvb_ca_en50221: Fix a bug for detecting CI MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfd94898-fabb-4089-8c04-42c2917f22dc@web.de>
Date: Thu, 23 May 2024 16:02:16 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: YongSu Yoo <yongsuyoo0215@...il.com>, linux-media@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Hyunwoo Kim <v4bel@...ori.io>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, yongsu.yoo@....com
Subject: Re: [PATCH] media: dvb_ca_en50221: Fix a bug for detecting CI MODULE

> 1. What is the "typo" ?

Please take another look at opportunities for spell checking
also in commit messages.

>>>> … right informtion. … a Bug. …

> 2. Can you take some examples which show the "Imperative wording" ?

I hope that you can take published guidance better into account
(instead of the wording “We fix this bug.” in the discussed changelog).
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94

> 3. Can you give me some examples for adding "Fixes" ?

An other tag specification might be more appropriate
than the following suggestion.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n145

Fixes: a75aa90c7c2f ("media: dvb_ca_en50221: Used a helper variable")

Regards,
Markus