linux-kernel - Re: [PATCH v2] drm/amd/display: Enable colorspace property for MST connectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39ca29dd-f072-43af-96ab-0fbe24bdda61@amd.com>
Date: Thu, 23 May 2024 10:02:59 -0400
From: Harry Wentland <harry.wentland@....com>
To: Mario Limonciello <mario.limonciello@....com>,
 dri-devel@...ts.freedesktop.org,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Cc: linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 Aurabindo Pillai <aurabindo.pillai@....com>,
 Daniel Wheeler <daniel.wheeler@....com>, Fangzhi Zuo <jerry.zuo@....com>,
 Ville Syrjälä <ville.syrjala@...ux.intel.com>,
 Tyler Schneider <tyler.schneider@....com>
Subject: Re: [PATCH v2] drm/amd/display: Enable colorspace property for MST
 connectors

On 2024-05-08 17:45, Mario Limonciello wrote:
> MST colorspace property support was disabled due to a series of warnings
> that came up when the device was plugged in since the properties weren't
> made at device creation. Create the properties in advance instead.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Fixes: 69a959610229 ("drm/amd/display: Temporary Disable MST DP Colorspace Property").
> Reported-and-tested-by: Tyler Schneider <tyler.schneider@....com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3353
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 941e96f100f4..12b036d511d0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -613,6 +613,9 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>   		&connector->base,
>   		dev->mode_config.tile_property,
>   		0);
> +	connector->colorspace_property = master->base.colorspace_property;
> +	if (connector->colorspace_property)
> +		drm_connector_attach_colorspace_property(connector);
>   
>   	drm_connector_set_path_property(connector, pathprop);
>