linux-kernel - Re: [PATCH] Bluetooth/nokia: Remove unused struct 'hci_nokia_radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 15:08:27 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: marcel@...tmann.org, luiz.dentz@...il.com
Cc: linux-bluetooth@...r.kernel.org, sre@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth/nokia: Remove unused struct
 'hci_nokia_radio_hdr'

* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'hci_nokia_radio_hdr' looks like it was unused since it's
> initial commit.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Ping?
I see a message from the bot asking for a change to the header
which I think wants Bluetooth: nokia: ?
(But then a load of segfaults in the test scripts).

Anything else?

Dave

> ---
>  drivers/bluetooth/hci_nokia.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
> index 97da0b2bfd17e..62633d9ba7c43 100644
> --- a/drivers/bluetooth/hci_nokia.c
> +++ b/drivers/bluetooth/hci_nokia.c
> @@ -116,11 +116,6 @@ struct hci_nokia_neg_evt {
>  #define SETUP_BAUD_RATE		921600
>  #define INIT_BAUD_RATE		120000
>  
> -struct hci_nokia_radio_hdr {
> -	u8	evt;
> -	u8	dlen;
> -} __packed;
> -
>  struct nokia_bt_dev {
>  	struct hci_uart hu;
>  	struct serdev_device *serdev;
> -- 
> 2.45.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/