linux-kernel - Re: [PATCH v2 00/35] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 16:18:07 +0100
From: Dave Martin <Dave.Martin@....com>
To: David Hildenbrand <david@...hat.com>
Cc: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, James Morse <james.morse@....com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	shameerali.kolothum.thodi@...wei.com,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	carl@...amperecomputing.com, lcherian@...vell.com,
	bobo.shaobowang@...wei.com,
	"Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
	baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>,
	Peter Newman <peternewman@...gle.com>, dfustini@...libre.com,
	amitsinght@...vell.com, Rex Nie <rex.nie@...uarmicro.com>
Subject: Re: [PATCH v2 00/35] x86/resctrl: Move the resctrl filesystem code
 to /fs/resctrl

Hi David,

On Thu, May 23, 2024 at 05:07:50PM +0200, David Hildenbrand wrote:
> On 23.05.24 17:01, Dave Martin wrote:
> > Hi Reinette,
> > 
> > Apologies for the slow response...
> > 
> > On Tue, May 14, 2024 at 08:56:41AM -0700, Reinette Chatre wrote:
> > > Hi Dave,
> > > 
> > > On 5/14/2024 8:17 AM, Dave Martin wrote:
> > > > On Wed, May 08, 2024 at 08:41:37AM -0700, Reinette Chatre wrote:
> > > > > On 4/26/2024 8:05 AM, Dave Martin wrote:
> > > > > > This is a respin of the resctrl refactoring series described below,
> > > > > > addressing review feedback.  Many thanks to those to responded with
> > > > > > feedback on the v1 series [2].
> > > > > > 
> > > > > > See Notes and FYIs in the individual patches for details on the changes
> > > > > > and outstanding issues.
> > > > > 
> > > > > What are your expectations regarding this series while considering [1] and [2]?
> > > > > 
> > > > > Reinette
> > > > > 
> > > > > [1] https://lore.kernel.org/lkml/ZiE8%2foXyjBef2qTy@e133380.arm.com/
> > > > > [2] https://lore.kernel.org/lkml/acce93e6-4c8e-472d-a2bc-5cbad2950661@intel.com/
> > > > > 
> > > > 
> > > > I plan to propose a reworked version of the fflags and string parser
> > > > stuff, and take a look at the other more minor outstanding issues.
> > > > 
> > > > The series does need rebasing, but otherwise I don't anticipate much
> > > > change to the code from the Arm side unless there are further review
> > > > comments.
> > > > 
> > > > Do you have a preference on how this series should proceed?
> > > 
> > > I believe that I already answered this question in [2], hence my confusion
> > > about this posting.
> > > 
> > > Reinette
> > 
> > I guess James and I need to tidy up the loose ends and repost this.
> > 
> > I'm hoping we can get a v3 out over the next few weeks or so.
> 
> Finally having more time to review this (I hope ...) does it make sense to
> review this v2 or wait for v3?

It's up to you.  All review is appreciated, but v2 mostly dealt with
minor cosmetic cleanups, and as Reinette highlights, there are few
more significant changes pending.

So, it may be a better use of your time if you wait for v3 and review
it then.

Cheers
---Dave